feat: setup webdriverio #2123
feat: setup webdriverio #2123
Conversation
|
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0019c0f:
|
anuraghazra
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
snitin315 and
saurabhdaware
as code owners
| @@ -0,0 +1,51 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
Do we want to write separate stories for E2E? what if test on stories that we write for documentation? This might also force us to cover more cases in documentation itself
There was a problem hiding this comment.
We can, but E2Es has very specific stories too, it might make the stories confusing if we just keep these as part of main stories.
There was a problem hiding this comment.
My concern is there's too many stories to write now ;__;
What if we keep the stories that we don't want to expose to consumer as Internal?
In most cases the stories we write for consumers would work for testing and for the cases where it doesn't, we can make them internal and then test on them?
| @@ -10,6 +10,14 @@ | |||
| "~tokens/*": ["src/tokens/*"], | |||
| "~src/*": ["src/*"] | |||
| }, | |||
| "types": [ | |||
There was a problem hiding this comment.
why do we have to define it like this? the import from package would resolve these types no?
There was a problem hiding this comment.
As part of their TS setup.
webdriver.io injects globals into the tests so we need these types to come up and modify the expect etc functions.
| ...commonCapabilities, | ||
| }, | ||
| }, | ||
| // Skipping safari for now, our storybook is broken in safari desktop :( |
There was a problem hiding this comment.
I am able to open it in my laptop 😕
There was a problem hiding this comment.
blade.razorpay.com?
What's your safari version? I'm using v15.4
packages/blade/wdio.bstack.conf.ts
Outdated
|
|
||
| const config = { ...baseConfig, ...bstackConfig }; | ||
|
|
||
| // Code to support common capabilities |
There was a problem hiding this comment.
Common capabilities of? also expected to be commented out?
|
@anuraghazra we can close this also? keep the branch so we can re-open |
Description
Changes
Additional Information
Component Checklist