chore: improve eslint performance #2166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eslint timing analysis before optimizations:
ignoreExternal: true
causes the performance to tank, and also changed the maxDepth from infinity to 4, I think 4 is enough to detect any cycles.import/no-deprecated
, this rule is the 3rd most expensive rule that was being run. This rule isn't really useful for blade.On average a 30s improvement.
Before: ~2.30s
After: 2m
Eslint timing analysis after optimizations:
Changes
Additional Information
Component Checklist