Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table controlled selection state [DSSUP-56] #2370

Closed
wants to merge 5 commits into from

Conversation

anuraghazra
Copy link
Member

Description

Fixes #2316

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: b609aa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 4, 2024

✅ PR title follows Conventional Commits specification.

Copy link

codesandbox-ci bot commented Oct 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b609aa3:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

rzpcibot commented Oct 4, 2024

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions, TableEditableCell, TableEditableDropdownCell 64.832 64.884 +0.052 KB

Generated by 🚫 dangerJS against b609aa3

@anuraghazra anuraghazra added the Review - L1 First level of review label Oct 9, 2024
@anuraghazra
Copy link
Member Author

Still waiting on react-table-library's dependency:

table-library/react-table-library#156

Marking this as draft for now.

@anuraghazra anuraghazra marked this pull request as draft November 11, 2024 07:58
@saurabhdaware
Copy link
Member

@anuraghazra We can close this and re-open when they revert maybe since that can take some time? keep the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review - L1 First level of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table]: Add support for controlled selection state in Table
3 participants