feat: ability to align individual table column items [FC-1234] #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1bff88c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1bff88c:
|
Bundle Size ReportUpdated Components
|
tewarig
changed the title
tewarig
changed the title
tewarig
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
tewarig
changed the title
tewarig
changed the title
anuraghazra
reviewed
Jan 15, 2025
| @@ -121,6 +124,14 @@ const StyledHeaderCell = styled(HeaderCell)<{ | |||
| ? makeSpace(getIn(theme, tableRow.paddingRight[$rowDensity])) | |||
| : undefined, | |||
| minHeight: makeSize(getIn(size, tableRow.minHeight[$rowDensity])), | |||
| '> .text': { | |||
There was a problem hiding this comment.
We should not use random classNames it may clash with consumer styles.
Add this styles directly in the box.
<BaseBox flexGrow display justifyContent>...</BaseBox>
anuraghazra
reviewed
Jan 21, 2025
anuraghazra
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr fixes #2319
This PR builds on the work done by @Sumitmaithani #2322
this pr adds ability to align individual table column to left or right.
before -
with - TableHeaderCell,TableCell,TableFooterCell with textAlgin= "right"
with TableHeaderCell,TableCell,TableFooterCell with textAlgin= "center"
Changes
added textAlign to tableHeader & tableCell
Additional Information
Component Checklist