Removed border variables on hover of menu-item, this is absent from t…

…he blank theme which means it isn't essential in our theme
rbouma · Oct 2, 2018 · c8ba804 · c8ba804
1 parent 95c3d01
commit c8ba804
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/src/scss/boilerplate/_menu.scss b/src/scss/boilerplate/_menu.scss
@@ -15,10 +15,6 @@
         &:hover {
           color: $menu-bar-menu-item-hover-color;
           background: $menu-bar-menu-item-hover-background;
-          border-top: $menu-bar-menu-item-hover-border-top;
-          border-bottom: $menu-bar-menu-item-hover-border-bottom;
-          border-left: $menu-bar-menu-item-hover-border-left;
-          border-right: $menu-bar-menu-item-hover-border-right;
         }
       }
 

diff --git a/src/scss/boilerplate/_variables.scss b/src/scss/boilerplate/_variables.scss
@@ -459,19 +459,14 @@ $menu-bar-menu-item-font-size: $font-default-font-size !default;
 $menu-bar-menu-item-color: $color-boilerplate-gray !default;
 
 $menu-bar-menu-item-hover-color: $color-boilerplate-black !default;
-$menu-bar-menu-item-hover-default-border: 3px solid $color-boilerplate-orange !default;
-$menu-bar-menu-item-hover-border-top: none !default;
-$menu-bar-menu-item-hover-border-bottom: $menu-bar-menu-item-hover-default-border !default;
-$menu-bar-menu-item-hover-border-left: none !default;
-$menu-bar-menu-item-hover-border-right: none !default;
 $menu-bar-menu-item-hover-background: $menu-bar-background !default;
 
 $menu-bar-menu-item-active-color: $menu-bar-menu-item-hover-color !default;
-$menu-bar-menu-item-active-default-border: $menu-bar-menu-item-hover-default-border !default;
-$menu-bar-menu-item-active-border-top: $menu-bar-menu-item-hover-border-top !default;
-$menu-bar-menu-item-active-border-bottom: $menu-bar-menu-item-hover-border-bottom !default;
-$menu-bar-menu-item-active-border-left: $menu-bar-menu-item-hover-border-left !default;
-$menu-bar-menu-item-active-border-right: $menu-bar-menu-item-hover-border-right !default;
+$menu-bar-menu-item-active-default-border: 3px solid $color-boilerplate-orange !default
+$menu-bar-menu-item-active-border-top: none !default;
+$menu-bar-menu-item-active-border-bottom: $menu-bar-menu-item-hover-default-border !default;
+$menu-bar-menu-item-active-border-left: none !default;
+$menu-bar-menu-item-active-border-right: none !default;
 $menu-bar-menu-item-active-background: $menu-bar-menu-item-hover-background !default;
 
 $menu-bar-menu-item-submenu-background: #ffffff !default;