Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close menu on click #15

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

isopropylcyanide
Copy link

This PR does the following:

  1. Closes the copy popup on click which is more intuitive than hovering outside.
  2. Refactor code to remove JSX warnings (=== in place of ==, not following JSX conventions, spaces etc)

@isopropylcyanide
Copy link
Author

Hi, can we merge this?

@rbrahul
Copy link
Owner

rbrahul commented Oct 8, 2019

Hi @isopropylcyanide Nowadays I became very busy with my personal job. I couldn't manage the time to test the behavior you implemented. Have you tested locally? If everything works as expected I can merge.

Copy link
Owner

@rbrahul rbrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hei your changes seem fine. Thanks for your contribution. I am going to merge it 🙂

@isopropylcyanide
Copy link
Author

Hi @isopropylcyanide Nowadays I became very busy with my personal job. I couldn't manage the time to test the behavior you implemented. Have you tested locally? If everything works as expected I can merge.

Yes, everything works as expected :) Thank you for the merge

@isopropylcyanide
Copy link
Author

@rbrahul Resolved merge conflicts. Can we merge this?

@isopropylcyanide
Copy link
Author

Bump @rbrahul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants