Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation and remove trailing semicolons #165

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

akinomyoga
Copy link
Contributor

@akinomyoga akinomyoga commented Jan 9, 2025

A few lines have the 2-space indentation. We fix them in this PR.

Also, several lines have suffix semicolons. Those semicolons might have been added by e.g. bash --pretty-print bash-preexec.sh, but we currently don't have such a semicolon for most of the lines anyway. There are two options for consistency:

  • We suffix semicolons to every line that can have a semicolon.
  • Or we remove all unnecessary semicolons.

In this PR, we choose the latter, the majority.

@akinomyoga
Copy link
Contributor Author

@rcaloras Could you also check other PRs, if possible? I think this one is a trivial fix, so it shouldn't take time to review.

Also, #160 would be another trivial one.

I also want to bring #96, which I reviewed and approved before, to your attention.

My other PRs are a bit non-trivial, so I understand that you would require some other reviewers.

I think issues #100 and #130 can be closed as resolved. #104 may also be closed because this seems to have been an external issue (or compatibility with an external setting), and the details needed to prepare any precautions, if we would do, are missing.

@rcaloras rcaloras merged commit e8e9024 into rcaloras:master Jan 13, 2025
1 check passed
@akinomyoga akinomyoga deleted the style branch January 13, 2025 03:30
@akinomyoga
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants