Skip to content

Commit

Permalink
Merge pull request #40 from samsonjs/fix/mbox-from-quoting
Browse files Browse the repository at this point in the history
Perform >From quoting as described by RFC 4155 (closes #37)
  • Loading branch information
rcarmo authored Jan 8, 2022
2 parents f91e5ec + 8a080fb commit 7cccc9d
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions imapbackup.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ def download_messages(server, filename, messages, config):
spinner = Spinner("Downloading %s new messages to %s" % (len(messages), filename),
config['nospinner'])
total = biggest = 0
from_re = re.compile("\n(>*)From ")

# each new message
for msg_id in messages.keys():
Expand All @@ -190,6 +191,11 @@ def download_messages(server, filename, messages, config):
# This avoids Thunderbird mistaking a line starting "From " as the start
# of a new message. _Might_ also apply to other mail lients - unknown
text = text.replace("\nFrom ", "\n From ")
else:
# Perform >From quoting as described by RFC 4155 and the qmail docs.
# https://www.rfc-editor.org/rfc/rfc4155.txt
# http://qmail.org/qmail-manual-html/man5/mbox.html
text = from_re.sub("\n>\\1From ", text)
mbox.write(text)
mbox.write('\n\n')

Expand Down
6 changes: 6 additions & 0 deletions imapbackup38.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ def download_messages(server, filename, messages, overwrite, nospinner, thunderb
spinner = Spinner("Downloading %s new messages to %s" % (len(messages), filename),
nospinner)
total = biggest = 0
from_re = re.compile(b"\n(>*)From ")

# each new message
for msg_id in messages.keys():
Expand Down Expand Up @@ -183,6 +184,11 @@ def download_messages(server, filename, messages, overwrite, nospinner, thunderb
# This avoids Thunderbird mistaking a line starting "From " as the start
# of a new message. _Might_ also apply to other mail lients - unknown
text_bytes = text_bytes.replace(b"\nFrom ", b"\n From ")
else:
# Perform >From quoting as described by RFC 4155 and the qmail docs.
# https://www.rfc-editor.org/rfc/rfc4155.txt
# http://qmail.org/qmail-manual-html/man5/mbox.html
text_bytes = from_re.sub(b"\n>\\1From ", text_bytes)
mbox.write(text_bytes)
mbox.write(b'\n\n')

Expand Down

0 comments on commit 7cccc9d

Please sign in to comment.