queue: check queue size at compile time #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit a compile-time error if a queue size is invalid, instead of a runtime error. This allows catching mistakes earlier, since the queue size is always defined at compile time. Unfortunately this means we must remove the corresponding test, as the only way to test a compile-time failure (without using external crates) is via doctests, which do not have access to private items (which is the case for VirtQueue). Signed-off-by: Carlos López <[email protected]>
qwandor
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a compile-time error if a queue size is invalid, instead of a runtime error. This allows catching mistakes earlier, since the queue size is always defined at compile time.
Unfortunately this means we must remove the corresponding test, as the only way to test a compile-time failure (without using external crates) is via doctests, which do not have access to private items (which is the case for
VirtQueue).