Make vsock buffer sizes configurable #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedataking
approved these changes
Jun 5, 2024
| Self { | ||
| driver, | ||
| connections: Vec::new(), | ||
| listening_ports: Vec::new(), | ||
| per_connection_buffer_capacity, |
There was a problem hiding this comment.
Are there any requirements on per_connection_buffer_capacity similar to RX_BUFFER_SIZE?
If so, would it make sense to validate the buffer size here or would an invalid buffer fail a check elsewhere?
There was a problem hiding this comment.
As far as I can tell the only requirement is that it fit in a u32, so I've changed the type to that.
The vsock protocol passes it as a u32, so we shouldn't allow anything bigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.