Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest playeropenrpc changes #207

Closed
wants to merge 4 commits into from
Closed

latest playeropenrpc changes #207

wants to merge 4 commits into from

Conversation

Nandana-NNR
Copy link
Contributor

No description provided.

// importing external Api resonse function, which can set the pre-requisite values to external modules
setExternalResponse(message) {
try {
const externalFunction = require('../../../plugins/setExternalApiResponse');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure that this require won't break OS when that file does not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Jacob, to address your concern, I have tested the usecase where the file required does not exist.
FCA still starts and behaves as normal with a 'warning' mentioning the module was not found
And since we have handled the code in a try-catch block..the playercreation fails as expected and we get the error message we are throwing from FCA. Basically the intention of requiring this function in the response handler is to handle response so that playerid in the response can be stored at fca side during player creation, which will be used for further calls. This code doesnot tamper with the existing functionality of FCA
image

@Nandana-NNR Nandana-NNR deleted the FIRECERT-2172 branch September 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants