Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dependencies on pubsub #230

Merged
merged 25 commits into from
Oct 28, 2024
Merged

Conversation

anjalimukundan
Copy link
Contributor

Description

Enter a detailed description of the PR here, including the nature and purpose of the changes.

JIRA Ticket

Include a link to the JIRA Ticket linked to this PR.
Issue-0000

Additional Info (Test steps / Steps to reproduce etc.)

Details on how to test the feature

Copy link

github-actions bot commented Oct 8, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/constant.js
  177:17  error  Replace `·:·"DEFAULT_APP_ID"` with `:·'DEFAULT_APP_ID'`  prettier/prettier
  178:14  error  Replace `·:·"DEFAULT_MAC"` with `:·'DEFAULT_MAC'`        prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/utils/Utils.js
  329:33  error  Delete `·`  prettier/prettier
  338:59  error  Insert `;`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented Oct 8, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/constant.js
  177:17  error  Delete `·`  prettier/prettier
  178:14  error  Delete `·`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  138:53  error  Insert `;`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Replace `action)` with `·action);`              prettier/prettier
  398:50  error  Replace `query.params)` with `·query.params);`  prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/pubSubClient.js
  52:41  error  Replace `this.PUBSUB_SUBSCRIBE_TOPIC_SUFFIX)` with `·this.PUBSUB_SUBSCRIBE_TOPIC_SUFFIX);`  prettier/prettier
  53:39  error  Replace `this.PUBSUB_PUBLISH_TOPIC_SUFFIX)` with `·this.PUBSUB_PUBLISH_TOPIC_SUFFIX);`      prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Insert `·`  prettier/prettier
  398:50  error  Insert `·`  prettier/prettier

/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/pubSubClient.js
  52:41  error  Insert `·`  prettier/prettier
  53:39  error  Insert `·`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  389:42  error  Insert `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  401:17  error  'test' is never reassigned. Use 'const' instead  prefer-const
  408:17  error  'test' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

src/App.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@neeradanelxsi neeradanelxsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are not as per requirement

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/utils/Utils.js
  176:15  error  Insert `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:


> [email protected] lint
> eslint .


/home/runner/work/firebolt-certification-app/firebolt-certification-app/src/App.js
  125:33  error  Delete `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

For more information on our linting policies, please see our Linting-Guide.

@Abhishk123 Abhishk123 merged commit efa81ba into dev Oct 28, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the Streamline_dependencies_on_pubsub branch October 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants