Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: FB interactions capturing #140

Merged
merged 33 commits into from
Aug 19, 2024
Merged

BREAKING CHANGE: FB interactions capturing #140

merged 33 commits into from
Aug 19, 2024

Conversation

Nandana-NNR
Copy link
Contributor

@Nandana-NNR Nandana-NNR commented Jul 3, 2024

No description provided.

Copy link

github-actions bot commented Jul 3, 2024

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  142:43  error  Insert `⏎···`  prettier/prettier
  405:32  error  Insert `⏎···`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Nandana-NNR Nandana-NNR requested a review from neeradanelxsi July 3, 2024 11:20
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  859:14  error  Replace `.assert(true,·`Firebolt·interactions·collection·service·${action}·successfully`)` with `⏎········.assert(true,·`Firebolt·interactions·collection·service·${action}·successfully`)⏎········`  prettier/prettier
  860:1   error  Replace `········` with `··········`                                                                                                                                                                  prettier/prettier
  861:1   error  Insert `··`                                                                                                                                                                                           prettier/prettier
  863:14  error  Insert `⏎········`                                                                                                                                                                                    prettier/prettier
  864:9   error  Insert `··`                                                                                                                                                                                           prettier/prettier
  865:1   error  Insert `··`                                                                                                                                                                                           prettier/prettier
  866:7   error  Replace `)` with `··)⏎········`                                                                                                                                                                       prettier/prettier
  867:1   error  Insert `··`                                                                                                                                                                                           prettier/prettier
  868:1   error  Insert `··`                                                                                                                                                                                           prettier/prettier

✖ 9 problems (9 errors, 0 warnings)
  9 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Eswar2103 Eswar2103 changed the title FIRECERT-2189-FB interactions capturing FB interactions capturing Jul 11, 2024
@rdkcmf-jenkins
Copy link

Coverity detected 1 issue; a quality concern.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  184:19  error  Replace `appIdentifier·=·null,·operation·=·null,·deviceIdentifier,·subscribeSuffix·=·null` with `⏎··appIdentifier·=·null,⏎··operation·=·null,⏎··deviceIdentifier,⏎··subscribeSuffix·=·null⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Hello feature Run failed ::

  1. Hello
    "before all" hook for "Hello":
    TypeError: Cannot read properties of null (reading 'addEventListener')

Because this error occurred during a before all hook we are skipping all of the remaining tests.
at Object.subscribe (http://localhost:41041/__cypress/tests?p=cypress/support/e2e.js:36050:19)
at Context.eval (http://localhost:41041/__cypress/tests?p=cypress/support/e2e.js:50863:22)

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1209:4  error  Insert `⏎`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/main.js
  121:67  error  Insert `;`  prettier/prettier

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Hello feature Run failed ::

  1. Hello
    "before all" hook for "Hello":
    AssertionError: Provided deviceMac is in improper format. Expected format : F046XXXXXXXX.

Because this error occurred during a before all hook we are skipping all of the remaining tests.
at Object.getTopic (http://localhost:37293/__cypress/tests?p=cypress/support/e2e.js:35331:11)
at Context.eval (http://localhost:37293/__cypress/tests?p=cypress/support/e2e.js:50881:30)

Copy link

Hello feature Run failed ::

  1. Hello
    "before all" hook for "Hello":
    AssertionError: Provided deviceMac is in improper format. Expected format : F046XXXXXXXX.

Because this error occurred during a before all hook we are skipping all of the remaining tests.
at Object.getTopic (http://localhost:41299/__cypress/tests?p=cypress/support/e2e.js:35331:11)
at Context.eval (http://localhost:41299/__cypress/tests?p=cypress/support/e2e.js:50881:30)

Copy link

Hello feature Run failed ::

  1. Hello
    "before all" hook for "Hello":
    AssertionError: Provided deviceMac is in improper format. Expected format : F046XXXXXXXX.

Because this error occurred during a before all hook we are skipping all of the remaining tests.
at Object.getTopic (http://localhost:45469/__cypress/tests?p=cypress/support/e2e.js:35331:11)
at Context.eval (http://localhost:45469/__cypress/tests?p=cypress/support/e2e.js:50881:30)

neeradanelxsi
neeradanelxsi previously approved these changes Aug 9, 2024
README.md Show resolved Hide resolved
kevinshahfws
kevinshahfws previously approved these changes Aug 12, 2024
jbigel
jbigel previously approved these changes Aug 13, 2024
neeradanelxsi
neeradanelxsi previously approved these changes Aug 14, 2024
@Eswar2103 Eswar2103 dismissed stale reviews from neeradanelxsi and jbigel via 9cdb144 August 19, 2024 04:52
Copy link

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

Copy link

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

@Eswar2103 Eswar2103 requested a review from Abhishk123 August 19, 2024 04:58
@Eswar2103 Eswar2103 changed the title FB interactions capturing BREAKING CHANGE: FB interactions capturing Aug 19, 2024
Copy link
Collaborator

@neeradanelxsi neeradanelxsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after pulling latest dev into the branch

@neeradanelxsi neeradanelxsi merged commit 940ed1b into dev Aug 19, 2024
6 of 7 checks passed
@neeradanelxsi neeradanelxsi deleted the FIRECERT-2189 branch August 19, 2024 14:49
@jbigel
Copy link
Contributor

jbigel commented Aug 20, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants