Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify all setter/getter test cases to JSV2 format #157

Merged
merged 9 commits into from
Aug 29, 2024
Merged

feat: Modify all setter/getter test cases to JSV2 format #157

merged 9 commits into from
Aug 29, 2024

Conversation

PreethiMaai
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/account.js
   2:3   error  Delete `··`                               prettier/prettier
   3:1   error  Delete `··`                               prettier/prettier
   4:3   error  Delete `··`                               prettier/prettier
   5:1   error  Replace `····` with `··`                  prettier/prettier
   6:1   error  Delete `··`                               prettier/prettier
   7:3   error  Delete `··`                               prettier/prettier
   8:1   error  Replace `····` with `··`                  prettier/prettier
   9:1   error  Delete `··`                               prettier/prettier
  10:5   error  Delete `··`                               prettier/prettier
  11:1   error  Replace `········` with `······`          prettier/prettier
  12:1   error  Delete `··`                               prettier/prettier
  13:9   error  Delete `··`                               prettier/prettier
  14:1   error  Replace `············` with `··········`  prettier/prettier
  15:1   error  Delete `··`                               prettier/prettier
  16:13  error  Delete `··`                               prettier/prettier
  17:1   error  Delete `··`                               prettier/prettier
  18:15  error  Delete `··`                               prettier/prettier
  19:13  error  Delete `··`                               prettier/prettier
  20:1   error  Delete `··`                               prettier/prettier
  21:9   error  Delete `··`                               prettier/prettier
  22:1   error  Delete `··`                               prettier/prettier
  23:1   error  Delete `··`                               prettier/prettier
  24:3   error  Delete `··`                               prettier/prettier
  25:1   error  Delete `··`                               prettier/prettier
  26:1   error  Delete `··`                               prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/audiodescriptions.js
   2:3   error  Delete `··`                               prettier/prettier
   3:1   error  Delete `··`                               prettier/prettier
   4:3   error  Delete `··`                               prettier/prettier
   5:1   error  Replace `····` with `··`                  prettier/prettier
   6:3   error  Delete `··`                               prettier/prettier
   7:3   error  Delete `··`                               prettier/prettier
   8:1   error  Delete `··`                               prettier/prettier
   9:3   error  Delete `··`                               prettier/prettier
  10:1   error  Delete `··`                               prettier/prettier
  11:3   error  Delete `··`                               prettier/prettier
  12:1   error  Replace `······` with `····`              prettier/prettier
  13:7   error  Delete `··`                               prettier/prettier
  14:1   error  Delete `··`                               prettier/prettier
  15:1   error  Replace `··········` with `········`      prettier/prettier
  16:11  error  Delete `··`                               prettier/prettier
  17:1   error  Delete `··`                               prettier/prettier
  18:1   error  Delete `··`                               prettier/prettier
  19:13  error  Delete `··`                               prettier/prettier
  20:1   error  Delete `··`                               prettier/prettier
  21:13  error  Delete `··`                               prettier/prettier
  22:1   error  Replace `············` with `··········`  prettier/prettier
  23:1   error  Delete `··`                               prettier/prettier
  24:7   error  Delete `··`                               prettier/prettier
  25:1   error  Delete `··`                               prettier/prettier
  26:3   error  Delete `··`                               prettier/prettier
  27:1   error  Delete `··`                               prettier/prettier
  28:1   error  Delete `··`                               prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/device.js
   2:3   error  Delete `··`                           prettier/prettier
   3:1   error  Delete `··`                           prettier/prettier
   4:3   error  Delete `··`                           prettier/prettier
   5:1   error  Replace `····` with `··`              prettier/prettier
   6:3   error  Delete `··`                           prettier/prettier
   7:1   error  Replace `····` with `··`              prettier/prettier
   8:1   error  Delete `··`                           prettier/prettier
   9:3   error  Delete `··`                           prettier/prettier
  10:1   error  Delete `··`                           prettier/prettier
  11:3   error  Delete `··`                           prettier/prettier
  12:1   error  Replace `······` with `····`          prettier/prettier
  13:7   error  Delete `··`                           prettier/prettier
  14:1   error  Delete `··`                           prettier/prettier
  15:1   error  Replace `··········` with `········`  prettier/prettier
  16:11  error  Delete `··`                           prettier/prettier
  17:1   error  Delete `··`                           prettier/prettier
  18:1   error  Delete `··`                           prettier/prettier
  19:13  error  Delete `··`                           prettier/prettier
  20:1   error  Delete `··`                           prettier/prettier
  21:1   error  Delete `··`                           prettier/prettier
  22:11  error  Delete `··`                           prettier/prettier
  23:1   error  Delete `··`                           prettier/prettier
  24:7   error  Delete `··`                           prettier/prettier
  25:1   error  Replace `······` with `····`          prettier/prettier
  26:1   error  Delete `··`                           prettier/prettier
  27:1   error  Replace `··};` with `};⏎`             prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/localization.js
   2:3   error  Delete `··`                           prettier/prettier
   3:3   error  Delete `··`                           prettier/prettier
   4:1   error  Delete `··`                           prettier/prettier
   5:3   error  Delete `··`                           prettier/prettier
   6:3   error  Delete `··`                           prettier/prettier
   7:1   error  Delete `··`                           prettier/prettier
   8:3   error  Delete `··`                           prettier/prettier
   9:1   error  Delete `··`                           prettier/prettier
  10:1   error  Delete `··`                           prettier/prettier
  11:3   error  Delete `··`                           prettier/prettier
  12:5   error  Delete `··`                           prettier/prettier
  13:1   error  Delete `··`                           prettier/prettier
  14:9   error  Delete `··`                           prettier/prettier
  15:9   error  Delete `··`                           prettier/prettier
  16:1   error  Delete `··`                           prettier/prettier
  17:13  error  Delete `··`                           prettier/prettier
  18:1   error  Delete `··`                           prettier/prettier
  19:1   error  Delete `··`                           prettier/prettier
  20:15  error  Delete `··`                           prettier/prettier
  21:13  error  Delete `··`                           prettier/prettier
  22:1   error  Delete `··`                           prettier/prettier
  23:1   error  Replace `··········` with `········`  prettier/prettier
  24:1   error  Delete `··`                           prettier/prettier
  25:1   error  Delete `··`                           prettier/prettier
  26:3   error  Delete `··`                           prettier/prettier
  27:1   error  Delete `··`                           prettier/prettier
  29:1   error  Delete `··`                           prettier/prettier
  30:3   error  Delete `··`                           prettier/prettier
  31:3   error  Delete `··`                           prettier/prettier
  32:1   error  Delete `··`                           prettier/prettier
  33:3   error  Delete `··`                           prettier/prettier
  34:5   error  Delete `··`                           prettier/prettier
  35:1   error  Delete `··`                           prettier/prettier
  36:9   error  Delete `··`                           prettier/prettier
  37:9   error  Delete `··`                           prettier/prettier
  38:1   error  Delete `··`                           prettier/prettier
  39:13  error  Delete `··`                           prettier/prettier
  40:1   error  Delete `··`                           prettier/prettier
  41:1   error  Delete `··`                           prettier/prettier
  42:15  error  Delete `··`                           prettier/prettier
  43:13  error  Delete `··`                           prettier/prettier
  44:1   error  Delete `··`                           prettier/prettier
  45:9   error  Delete `··`                           prettier/prettier
  46:1   error  Delete `··`                           prettier/prettier
  47:1   error  Delete `··`                           prettier/prettier
  48:3   error  Delete `··`                           prettier/prettier
  49:1   error  Replace `··};` with `};⏎`             prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/metrics.js
   2:3   error  Delete `··`                           prettier/prettier
   3:3   error  Delete `··`                           prettier/prettier
   4:1   error  Delete `··`                           prettier/prettier
   5:3   error  Delete `··`                           prettier/prettier
   6:3   error  Delete `··`                           prettier/prettier
   7:1   error  Replace `······` with `····`          prettier/prettier
   8:7   error  Delete `··`                           prettier/prettier
   9:1   error  Delete `··`                           prettier/prettier
  10:1   error  Replace `··········` with `········`  prettier/prettier
  11:11  error  Delete `··`                           prettier/prettier
  12:1   error  Delete `··`                           prettier/prettier
  13:13  error  Delete `··`                           prettier/prettier
  14:13  error  Delete `··`                           prettier/prettier
  15:1   error  Delete `··`                           prettier/prettier
  16:13  error  Delete `··`                           prettier/prettier
  17:1   error  Delete `··`                           prettier/prettier
  18:1   error  Replace `··········` with `········`  prettier/prettier
  19:1   error  Delete `··`                           prettier/prettier
  20:1   error  Delete `··`                           prettier/prettier
  21:3   error  Delete `··`                           prettier/prettier
  22:1   error  Replace `··};` with `};⏎`             prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/privacy.js
   2:3   error  Delete `··`                           prettier/prettier
   3:3   error  Delete `··`                           prettier/prettier
   4:1   error  Delete `··`                           prettier/prettier
   5:1   error  Replace `····` with `··`              prettier/prettier
   6:3   error  Delete `··`                           prettier/prettier
   7:3   error  Delete `··`                           prettier/prettier
   8:1   error  Delete `··`                           prettier/prettier
   9:3   error  Delete `··`                           prettier/prettier
  10:3   error  Delete `··`                           prettier/prettier
  11:3   error  Delete `··`                           prettier/prettier
  12:1   error  Replace `······` with `····`          prettier/prettier
  13:7   error  Delete `··`                           prettier/prettier
  14:1   error  Delete `··`                           prettier/prettier
  15:1   error  Replace `··········` with `········`  prettier/prettier
  16:11  error  Delete `··`                           prettier/prettier
  17:1   error  Delete `··`                           prettier/prettier
  18:1   error  Delete `··`                           prettier/prettier
  19:13  error  Delete `··`                           prettier/prettier
  20:1   error  Delete `··`                           prettier/prettier
  21:1   error  Delete `··`                           prettier/prettier
  22:11  error  Delete `··`                           prettier/prettier
  23:1   error  Delete `··`                           prettier/prettier
  24:7   error  Delete `··`                           prettier/prettier
  25:1   error  Replace `······` with `····`          prettier/prettier
  26:1   error  Delete `··`                           prettier/prettier
  27:1   error  Replace `··};` with `};⏎`             prettier/prettier

✖ 172 problems (172 errors, 0 warnings)
  172 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/fixtures/fireboltCalls/localization.js
  81:3  error  Insert `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@github-actions GitHub Actions
Copy link

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

@PreethiMaai PreethiMaai changed the title Modify all setter/getter test cases to JSV2 format feat: Modify all setter/getter test cases to JSV2 format Aug 19, 2024
jbigel
jbigel previously approved these changes Aug 19, 2024
View reviewed changes
neeradanelxsi
neeradanelxsi previously approved these changes Aug 22, 2024
View reviewed changes
@PreethiMaai PreethiMaai dismissed stale reviews from neeradanelxsi and jbigel via 784f30c August 27, 2024 08:49
@Abhishk123 Abhishk123 merged commit bd6fa9b into dev Aug 29, 2024
6 checks passed
@Abhishk123 Abhishk123 deleted the Testcases-modification-to-JSV2 branch August 29, 2024 06:10
jbigel pushed a commit that referenced this pull request Aug 29, 2024
@semantic-release-bot
chore(release): 1.2.0-dev.4 [skip ci]
99afb99 
# [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2024-08-29)

### Features

* Modify all setter/getter test cases to JSV2 format ([#157](#157)) ([bd6fa9b](bd6fa9b))
@jbigel
Copy link
Contributor

jbigel commented Aug 29, 2024

🎉 This PR is included in version 1.2.0-dev.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
5d5f06a 
# [1.2.0](v1.1.0...v1.2.0) (2024-09-12)

### Bug Fixes

* Exempted methods does not have error null check for error ([#195](#195)) ([3eac88e](3eac88e))
* updated miscValidation logs of advertising ([#187](#187)) ([31145af](31145af))

### Features

* Add support for skipping individual scenarios from beforeEach operation ([#205](#205)) ([b7e2257](b7e2257))
* added support in env setup glue for fetching device details dynamically ([#188](#188)) ([85a8f77](85a8f77))
* added support to process array in static v2 ([#210](#210)) ([9a49910](9a49910))
* Changed suite default communication mode to Transport ([#202](#202)) ([5d52c12](5d52c12))
* Implement new metrics API for 1.3.0 release ([#167](#167)) ([cd3062e](cd3062e))
* Modify all setter/getter test cases to JSV2 format ([#157](#157)) ([bd6fa9b](bd6fa9b))
@jbigel
Copy link
Contributor

jbigel commented Sep 12, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeier204 jmeier204 jmeier204 approved these changes

@jbigel jbigel jbigel left review comments

@neeradanelxsi neeradanelxsi neeradanelxsi left review comments

Assignees
No one assigned
Labels
released on @dev released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PreethiMaai @jbigel @neeradanelxsi @jmeier204 @Abhishk123