Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(windows): fix Windows example app not loading #1123

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 18, 2024

Summary

Fix Windows example app not loading.

While I was in there, I also removed a dupe of metro.

Resolves #1122.

Test Plan

On a Windows machine:

cd packages/default-storage
yarn start

In a browser, open: http://localhost:8081/index.bundle?platform=windows&dev=true&hot=true&inlineSourceMap=true

Screenshots

image

@tido64 tido64 requested a review from krizzu as a code owner July 18, 2024 07:44
Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 9e3c50c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tido64 tido64 merged commit 133475f into main Jul 18, 2024
8 checks passed
@tido64 tido64 deleted the tido/fix-windows-app branch July 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run the example app on Windows after 0.73 bump
2 participants