chore(apple): fix build issues discovered internally

[Saadnajmi]

Summary

At my side of Microsoft, we have recently "vendored" a couple of libraries. Which means, we started building them from source using our own generated Xcode project (not the one cocoapods generates), which has much stricter build flags / treats warnings as errors. In doing so, I caught a couple of issues in React Native async-storage I'd like to push back up!

Namely:

• Fix warnings where we need to add a bunch of either __nullable or __nonnull specifiers.
• Fix a "declaration of variable shadows another local variable" where we had two NSError *error = nil declarations in a row
• Fix another "declaration of variable shadows another local variable" with two NSError variables by renaming one of them
• Add an __unused clang tag to a parameter
• Add __autoreleaseing clang tags to two more parameters.
  • The error internally without these was Method parameter of type 'NSMutableArray<NSDictionary *> *__autoreleasing *' with no explicit ownership, for the record.

Test Plan

CI should pass

[changeset-bot]

🦋 Changeset detected

Latest commit: b0d402d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@react-native-async-storage/async-storage	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tido64]

Thanks for the fixes 🙏

[tido64]

⚠️ No Changeset found

Latest commit: abafda4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Oh, can you add a change log?