fix: Fix made to handle if mode in command argument includes build flavor … #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flavor as well, i.e. productionDebug. react-native-community#2323
cortinico
approved these changes
Mar 8, 2024
thymikee
reviewed
Apr 17, 2024
| // handle if selected task from interactive mode includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array | ||
| const variantFromSelectedTask = selectedTask | ||
| // handle if selected task from interactive mode, or mode from arguments, includes build flavour as well, eg. installProductionDebug should create ['production','debug'] array | ||
| const variantFromSelectedTask = (selectedTask ?? args.mode) |
There was a problem hiding this comment.
@szymonrybczak @adamTrz should we do the fallback here or set selectedTask to args.mode in non-interactive mode, if that makes sense?
|
If this is working fine, can we please merge it? |
|
This fixes my issue installing the app on a device. |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change addresses the bug #2323 reported for
yarn react-native run-androidwith product flavor.Test Plan:
Fix made locally and tested by installing on simulator, please refer below screenshot.
Checklist