Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version of react-dom in package.json #12

Conversation

jsms90
Copy link

@jsms90 jsms90 commented Dec 5, 2018

react-dom is a peer dependency of styled-components & a version higher than 16.3.0 is required for styled components to function correctly

This PR alters the version required in the package.json, so that completing Part 1 of the exercise will be enough to get things up and running for Part 3

Fixes #10

as this version is a peer dependency of styled components
@ric9176
Copy link
Member

ric9176 commented Dec 10, 2018

thanks @jsms90 I've updated this one manually as the package-lock was blocking the merge. Thanks again 😄

@ric9176 ric9176 closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants