Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom router API #51

Merged
merged 8 commits into from
Jan 12, 2025
Merged

Custom router API #51

merged 8 commits into from
Jan 12, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 12, 2025 •
edited
Loading

Description

This PR plays around with the ReactPy-Router's internals to make custom routers possible.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review January 12, 2025 11:05
@Archmonger Archmonger requested a review from a team as a code owner January 12, 2025 11:05
@Archmonger Archmonger changed the title Custom router interface Custom router API Jan 12, 2025
@Archmonger Archmonger merged commit 88ec72f into reactive-python:main Jan 12, 2025
12 checks passed
@Archmonger Archmonger deleted the add-MatchedRoute-type branch January 12, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CompiledRoute.resolve to return a dataclass, not a tuple Create docs for "Creating a Custom Router"
1 participant
@Archmonger