Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky test #1158

Merged
merged 1 commit into from
Oct 22, 2023
Merged

fix flaky test #1158

merged 1 commit into from
Oct 22, 2023

Conversation

rmorshea
Copy link
Collaborator

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

This build failed due to a flaky test.

Solution

Ensure the view has rendered by the time we try to access the hook callback.

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

@rmorshea rmorshea marked this pull request as ready for review October 22, 2023 19:04
@rmorshea rmorshea merged commit d3959e4 into reactive-python:main Oct 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmorshea