-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reactpy.backend.hooks
module into reactpy.core.hooks
#1210
Move reactpy.backend.hooks
module into reactpy.core.hooks
#1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after resolving my minor nitpick.
506cac7
to
908206c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some formatting fixes to pass linting tests.
Also, coverage is failing right now. You'll need to convert the existing tests to use your new hooks, and add # nocov
to the top of the deprecated file.
db61cc7
to
51cd038
Compare
I'm having trouble with adding the # nocov comment at the top of backend.hooks. It seems to only be working on the first import line instead of the whole file. |
Hmm I thought there was a way to do it for the whole file. Worst case you could add that comment to each individual hook in the file. |
I decided to add nocov comments to every import/function. Let me know if there's a more concise way to do it, because I couldn't figure it out. |
Still not passing lint: EDIT: Might be unrelated to your changes? If so, you can pin |
Why do you mean by pin mypy? |
I don't see how my changes could have caused the lint error we're seeing, so I think I'm good to add |
Description
Fixes #1182 - Moves the hooks in
reactpy.backend.hooks
intoreactpy.core.hooks
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).