Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2-migrate-mypy-to-pyright #1274

Merged
merged 2 commits into from
Feb 11, 2025
Merged

V2-migrate-mypy-to-pyright #1274

merged 2 commits into from
Feb 11, 2025

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Feb 11, 2025 •
edited
Loading

Description

  • Change our preferred type checker from MyPy to Pyright
  • Don't rely on asgiref.types as much, since they're a bit too strict and cause a lot of type errors in use code.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger marked this pull request as ready for review February 11, 2025 02:39
@Archmonger Archmonger merged commit d5a897e into reactive-python:develop Feb 11, 2025
17 checks passed
@Archmonger Archmonger deleted the v2-migrate-mypy-to-pyright branch February 11, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Archmonger