Manage list view #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a library for Java micro services manipulating common Reactivity POJOs. The fundamental class defined in this commit are ReactivityEntity, which represents a base class for any entity and Event which allows to generate a Reactivity event wrapping an entity.
Add the POJOs that allow to manage a list view with a type defined in an ViewType enumeration. A list view allows to manage artifacts and belongs to an organization.
First endpoints returning a Flux typed with Event<? ReactivityEntity> are introduced by this commit to: - retrieve a mocked organization with a single list view - subscribe to this mocked organization and receive associated view with its corresponding artifacts - retrieve some additional artifacts matching a specific period of time The view selects the 100 newest artifacts when the user subscribes to the organization. A mocked index.html shows how this web service can be called and then retrieve older artifacts based on the last received events. The endpoints are currently not suspending a SSE connection because Reactor currently broadcast any event to all connections, which is not what we want for this use case. It's plan in a future release of Reactor to provide such capability. Flux are configured to fallback to an Event<Error> publisher in case of exception or timeout. This mechanism needs to be improved with retry capabilities, including replica usage for couchbase, that meet circuit-breaking capabilities. There's still a random issue (under investigation) where no artifacts is returned by N1QL query in couchbase the first time a web service is called. Also, log4j2 is raising an exception when called by Reactor through SLF4J and that's why it's not present in this commit.
Repository methods now always return a ReactivityEntity because it can be an Error instead of the targeted type in case of success. This allows to notify the subscriber that an exception occurred instead of raise a timeout and also to not swallow the exception.
gdrouet
force-pushed
the
issue4-sse-couchbase
branch
24 times, most recently
from
1457f56 to
da35b33
Compare
gdrouet
force-pushed
the
issue4-sse-couchbase
branch
7 times, most recently
from
7e92d0a to
c0ce314
Compare
This commit introduces the spring-rest-docs support. All EventController endpoinds are documented and generated snippets are pushed to a "doc-snippets" branch that can be used in the reactivity-doc project. Currently unit tests are mixing MockMvc with webflux module, which works even if a more adapted support for webflux tests has to be considered.
gdrouet
force-pushed
the
issue4-sse-couchbase
branch
from
c0ce314 to
5dd3c59
Compare
Injector.provide to register a new Service
myPolymerElement.requestProvider('mon-service') to inject the service
Non-standard changes have been made to use spring-restdocs with MockMvc as WebClientTest from spring-webflux is currently not supported. Those changes introduce failures depending of internal changes of spring framework and can't stay activated. They are disabled from now. Since WebClientTest won't be supported soon, a true integration test approach should be considered on the short term where spring-restdocs can be leveraged through rest-assured
All text files now have a LF line separator.
gdrouet
force-pushed
the
issue4-sse-couchbase
branch
from
5b260ba to
7c7007a
Compare
This commit removes all snapshots related to spring framework. Spring boot 2.0.0.M1 version is now used and embeds spring 5.0.0.RC1 version. Reactor 3.1.0.M1 also now replaces 3.0.x main line and breaking changes have been fixed accordingly.
remove rc
Signed-off-by: gdrouet <[email protected]>
Signed-off-by: gdrouet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the scope of the
broadcastermicro service in #4 which allows to deal with a list view.