Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflicts #71

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Resolve merge conflicts #71

merged 1 commit into from
Sep 16, 2024

Conversation

rammba
Copy link
Collaborator

@rammba rammba commented Sep 16, 2024

I saw there are few merge conflicts so this it the first thing I want to fix.

@lxmarinkovic
Copy link
Collaborator

@rammba thanks for the effort; I'll try to review it reasonably soon :D

@rammba
Copy link
Collaborator Author

rammba commented Sep 16, 2024

The reason why pipeline fails is the change on parent repo, which is not yet propagated here.

Copy link
Collaborator

@lxmarinkovic lxmarinkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@lxmarinkovic lxmarinkovic merged commit fbb7e9d into main Sep 16, 2024
2 of 3 checks passed
@lxmarinkovic lxmarinkovic deleted the fix/merge-conflicts branch September 16, 2024 17:29
@lxmarinkovic
Copy link
Collaborator

The reason why pipeline fails is the change on parent repo, which is not yet propagated here.

I think I fixed that now :D

@rammba
Copy link
Collaborator Author

rammba commented Sep 16, 2024

Great, we have working version @ sr-react-dev.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants