Fix recordPendingSuccess/FailureAndLatency not recorded without timeout
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violetagg
requested changes
May 15, 2024
There was a problem hiding this comment.
@HeartPattern Thanks for the PR!
Please update the copyright end year with the following command ./gradlew :spotlessApply
Can you please provide test similar to reactor.pool.CommonPoolTest#recordsPendingCountAndLatencies
HeartPattern
force-pushed
the
fix-record-pending-without-timeout
branch
from
f006c81
to
e5b61ca
Compare
pderop
reviewed
May 16, 2024
pderop
approved these changes
May 16, 2024
|
@violetagg, can you re-review this ? |
violetagg
changed the title
recordPendingSuccess/FailureAndLatency not recorded without timeout
violetagg
pushed a commit
that referenced
this pull request
May 17, 2024
|
I back ported this fix to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recordPendingSuccess/FailureAndLatency seems not recorded properly without timeout.
If we call acquire() without timeout, timeoutTask remain as TIMEOUT_DISPOSED since AbstractPool#430 check if pendingAcquireTimeout is non-zero.