-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RAs views #289
Update RAs views #289
Conversation
see #277 The text content is waiting to be filled up. The sub-headings are just place-holders to indicate where to input what. They can be modified soon in the future. @LenaHenningsen
Hi Qin, lovely work! A few minor things:
Thanks a lot for all your work and let me know if things are unclear! All best Lena |
Thanks for detailed instruction. All the requirements are done. One question left and also one observation to mention. The question is: Is "The Class Teacher" counted as a book title? And its Chinese translation "班主任"? And "Diary of a Madman"? And the observation to mention is that: The view in the section "Popular authors" seems to have a lot of whitespace below the picture. I checked, it looks a bit suspicious but the output is correct. If one scroll the picture to the very right side, one can see the illustrations of what color represents what. |
Diary of a Madman and The Class Teacher are both short stories, therefore they should be given in "...", but not in italics. |
Thanks for illustration. They are kept in the way of using double quotes. Just checked again. |
May you wait to merge this PR until tomorrow(Monday) instead of today? I am double checking the data in views right now. Friday I worked 4 hours on learning more about SQL and hasn't finished the checking of the views on Friday. I'll write you more via basecamp soon (Wanted to write you yesterday but I was thinking it might be better to not write you on weekend). |
Take your time, just let me know once you are happy with everything. (And sorry for writing back on a weekend!) |
thanks and no problem. I feel I started the messages anyway... Sorry |
Hi Lena, once the latest PR on ReadAct is merged, this PR can be merged as well. |
I need a bit time to manually go through view tables for eliminating duplicated rows. Will make this PR ready after that. |
Sure, no worries. I am off now and have made a note of it for tomorrow. You can just send me a message once you are done and happy with merging.
Von: Qin Gu ***@***.***>
Antworten an: "readchina/readchina.github.io" ***@***.***>
Datum: Dienstag, 20. Juni 2023 um 14:36
An: "readchina/readchina.github.io" ***@***.***>
Cc: Lena Henningsen ***@***.***>, Review requested ***@***.***>
Betreff: Re: [readchina/readchina.github.io] Update RAs views (PR #289)
I need a bit time to manually go through view tables for eliminating duplicated rows. Will make this PR ready after that.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Hi Lena, could you merge the PR on ReadAct first, and then this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Qin, it all looks nice with one exception. The first chart (RA from autobiographical sources) is quite odd: it now only contains 1 item... Could you double check? The rest looks beautiful. Lena
Sorry! Gonna check now |
I fixed it by open a new PR on ReadAct. |
Hooray |
Three Vega views on ReadAct page of the ReadChina website are updated. They are:
Reading acts with autobiography sources
Reading Acts in Chinese Fictional Texts ( specified with science fiction genre for the source of reading acts)
Reading Acts in Chinese Fictional Texts
The text of the ReadAct page are updated accordingly.
See #277