Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): repo maintenance #255

Merged
merged 6 commits into from
Apr 18, 2024
Merged

chore(deps-dev): repo maintenance #255

merged 6 commits into from
Apr 18, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented Apr 18, 2024 •
edited
Loading

🧰 Changes

  • Bumping all out of date dependencies.
  • Removes all browser testing. It's incredibly broken in CI and instead of being forced to use some very old version of Karma because of @jsdevtools/karma-config I'd rather put effort into moving the codebase to TS and unit testing to Vitest.
    • I also want to get away from chai because they went ESM-only and would rather move everything to Vitest than deal with ESMing just for chai.
    • Karma is also deprecated now too.
  • Removes Husky because we don't really need it here.

@erunion erunion added the refactor Issues about tackling technical debt label Apr 18, 2024
@erunion erunion requested a review from kanadgupta April 18, 2024 00:32
kanadgupta
kanadgupta approved these changes Apr 18, 2024
View reviewed changes
test/specs/object-source/object-source.spec.js Outdated Show resolved Hide resolved
.husky/commit-msg Outdated Show resolved Hide resolved
package.json
"sinon": "^17.0.0",
"typescript": "^5.3.3"
"typescript": "^5.4.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just saw how this library uses TS and... woof

erunion and others added 3 commits April 18, 2024 09:00
@erunion @kanadgupta
Update test/specs/object-source/object-source.spec.js
9e9e414 
Co-authored-by: Kanad Gupta <[email protected]>
@erunion
feat: expose the total amount of validation schema errors (#254)
0fdcbc0 
* feat: expose the total amount of validation schema errors

* fix: broken test?

* fix: broken test???

* fix: try again????
@erunion
ci: adding a pr title linter
1dbdae4
@erunion erunion merged commit 329728e into main Apr 18, 2024
4 checks passed
@erunion erunion deleted the chore/repo-maintenance branch April 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @kanadgupta