feat(breaking): dropping support for callback handling #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
approved these changes
Jan 31, 2025
| @@ -71,6 +71,10 @@ import OpenAPIParser from '@readme/openapi-parser'; | |||
|
|
|||
| ## Differences from `@apidevtools/swagger-parser` | |||
|
|
|||
| The methods on `@readme/openapi-parser`, unlike `@apidevtools/swagger-parser`, do not support callbacks. | |||
| @@ -26,7 +26,7 @@ function validateSpec(api) { | |||
| const path = api.paths[pathName]; | |||
| const pathId = `/paths${pathName}`; | |||
|
|
|||
| if (path && pathName.indexOf('/') === 0) { | |||
| if (path && pathName.startsWith('/')) { | |||
There was a problem hiding this comment.
more like es-boomer syntax amirite
There was a problem hiding this comment.
doesn't have to happen in this PR obviously but if we plan on maintaining this long term i think we should probably just do a proper conversion to TS?
There was a problem hiding this comment.
wild how much bloat callbacks support added to this file. woof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
In order to update this library to support the newest version of
json-schema-ref-parserwe're dropping support for callbacks.