Data validation: allow multiple_versions_without_translations (#232)

This is a valid value that I missed when I upgraded this code. Solves issue reported at pypa/pipx#698 (comment)
readthedocs · Jan 17, 2024 · b59eb1d · b59eb1d
1 parent a3f89f5
commit b59eb1d
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 3 deletions.
diff --git a/dist/readthedocs-addons.js b/dist/readthedocs-addons.js
diff --git a/dist/readthedocs-addons.js.map b/dist/readthedocs-addons.js.map
diff --git a/src/data-validation.js b/src/data-validation.js
@@ -174,6 +174,7 @@ const addons_flyout = {
             versioning_scheme: {
               enum: [
                 "multiple_versions_with_translations",
+                "multiple_versions_without_translations",
                 "single_version_without_translations",
               ],
             },
@@ -287,6 +288,7 @@ const addons_notifications = {
             versioning_scheme: {
               enum: [
                 "multiple_versions_with_translations",
+                "multiple_versions_without_translations",
                 "single_version_without_translations",
               ],
             },

diff --git a/tests/flyout.test.js b/tests/flyout.test.js
@@ -71,6 +71,38 @@ describe("Flyout addon", () => {
       }),
     ).to.be.true;
   });
+
+  // This test is a copy of the previous one.
+  // We should probably create a `config` variable and adapt it depending on the test,
+  // instead of duplicating the whole object.
+  it("enabled with multiple_versions_without_translations", () => {
+    expect(
+      FlyoutAddon.isEnabled({
+        addons: {
+          flyout: {
+            enabled: true,
+            downloads: [],
+            translations: [],
+            versions: [],
+          },
+        },
+        domains: {
+          dashboard: "readthedocs.org",
+        },
+        projects: {
+          current: {
+            slug: "project",
+            versioning_scheme: "multiple_versions_without_translations",
+          },
+        },
+        versions: {
+          current: {
+            slug: "latest",
+          },
+        },
+      }),
+    ).to.be.true;
+  });
 });
 
 describe("Flyout element", () => {