Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New landing page to test marketing copy #152
New landing page to test marketing copy #152
Changes from 3 commits
ccf6db6
79be83a
ee00657
15ab468
51a23ed
7e107ff
3fdc509
6f11e8a
4eb40a2
c6f19ff
42a92a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header doesn't match the content below. This header sounds fairly vague and generic, but it's also saying "Read the Docs provides all the services you need to host your documentation in one place". The content doesn't agree with this, and is instead "how to host your Sphinx project on Read the Docs".
No strong preference here, but same energy but more specific benefit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the nesting of elements here is wrong. The heading should be outside the grid, and should be at least inside the
div.container
, and the grid shouldn't need adiv.row
class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the HTML structure. I edited the header for now so this doesn't get lost, but not sold on the edit copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to #152 (comment)