Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Obj trivial and add a separate ObjCollectionParent type #7402

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Make Obj trivial and add a separate ObjCollectionParent type #7402

merged 6 commits into from
Mar 13, 2024

Commits on Mar 12, 2024

  1. Store less data for notification tracking on collections in Mixed 

    We only need the very next path element, not the entire remaining path.
    @tgoyne
    tgoyne committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5edb85d View commit details
    Browse the repository at this point in the history

  2. Fix a data race in collection notifier logging and extract some dupli… 

    …cated code

m_run_time_point was read on the target thread while being written on the
worker thread without any locking involved.
    @tgoyne
    tgoyne committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0e94a90 View commit details
    Browse the repository at this point in the history

  3. Consolidate collection updating logic somewhat

    @tgoyne
    tgoyne committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1792e59 View commit details
    Browse the repository at this point in the history

  4. Make Obj trivial and add a separate ObjCollectionParent type 

    Giving Obj a virtual base class turns out to have a meaningful performance
impact.
    @tgoyne
    tgoyne committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    08546b7 View commit details
    Browse the repository at this point in the history

  5. Restore util::NullLogger rather than duplicating it each place it's used

    @tgoyne
    tgoyne committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    916881b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Add more UpdateIfNeeded tests

    @tgoyne
    tgoyne committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    728ba67 View commit details
    Browse the repository at this point in the history