Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test #7446

Closed
wants to merge 5 commits into from
Closed

Update test #7446

wants to merge 5 commits into from

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Mar 11, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

tgoyne and others added 5 commits March 8, 2024 09:07
@tgoyne
Store less data for notification tracking on collections in Mixed
5996189 
We only need the very next path element, not the entire remaining path.
@tgoyne
Fix a data race in collection notifier logging and extract some dupli…
cc6d640 
…cated code

m_run_time_point was read on the target thread while being written on the
worker thread without any locking involved.
@tgoyne
Consolidate collection updating logic somewhat
1a5ee38
@tgoyne
Make Obj trivial and add a separate ObjCollectionParent type
d05739a 
Giving Obj a virtual base class turns out to have a meaningful performance
impact.
@jedelbo
Update test
3c36d09
@cla-bot cla-bot bot added the cla: yes label Mar 11, 2024
@jedelbo jedelbo mentioned this pull request Mar 11, 2024
Merged
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_137

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.9%) to 90.929%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/instruction_replication.cpp 1 90.52%
test/fuzz_group.cpp 2 52.12%
src/realm/alloc_slab.cpp 5 92.93%
src/realm/sync/noinst/client_impl_base.cpp 5 85.34%
src/realm/index_string.cpp 6 87.49%
Totals Coverage Status
Change from base Build thomas.goyne_223: 0.9%
Covered Lines: 238527
Relevant Lines: 262321
💛 - Coveralls

Base automatically changed from tg/obj-perf to master March 13, 2024 04:51
@tgoyne
Copy link
Member

tgoyne commented Mar 13, 2024

Added this test plus some more to #7402.

@tgoyne tgoyne closed this Mar 13, 2024
@tgoyne tgoyne deleted the je/collection-updating branch March 13, 2024 04:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jedelbo jedelbo

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedelbo @tgoyne