Feature/string compression #7803
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
* No unique ptrs for string interner + limit number of interners * point fix client-reset test * code review
jedelbo
force-pushed
the
feature/string-compression
branch
from
8e8356c
to
8f1d472
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_334Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build jorgen.edelbo_338Details
💛 - Coveralls |
* find_first optimization for compressed strings * core test passing * compression tests for collection of strings * code review * Fixes (#7872) --------- Co-authored-by: Jørgen Edelbo <[email protected]>
nicola-cab
force-pushed
the
feature/string-compression
branch
from
a7e04bb
to
d35c8fc
Compare
Pull Request Test Coverage Report for Build jorgen.edelbo_402Details
💛 - Coveralls |
…f is compressed (#7880) * use CompressedViewString cmp for compressed leaves * fix asan * code review * fix redudant code
…e fast comparison provided by the interner (#7892) * initial test * add logic for fetching stringID to Descriptors (partially working) * fixes core tests * ops I cannot use C++20 :-) * fix test * fix handling for array mixed when it holds strings * fix improper use of mixed when it is not string * Compare only if both string ids are available * works for strings * enable mixed and fix bug in cmp function * code cleanup * remove alias dup * fix cmp function + simplify comparison function for sorting * lint * more readeable cmp function * test refactory, still missing cmp over links + mixed of diff type cmp * tests * code review * more tests for utf8 * code review * code review
RCORE-2233 Reduce locking for StringInterner lookup and compare methods
When writing the realm to a new file from a write transaction, the Table may be COW so that the top ref is changed. So don't use the ref that is present in the group when the operation starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed