Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing scheduler to EventLoopDispatcher, schedulerWrapBlockingFunction and through RealmConfig #7903

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This allows the JS SDK to pass a util::Scheduler to the EventLoopDispatcher and schedulerWrapBlockingFunction utilities as well as through the RealmConfig when opening a Realm.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kraenhansen kraenhansen marked this pull request as draft August 26, 2024 12:57
@kraenhansen
Copy link
Member Author

This could probably merge, but it's unlikely that the JS PR depending on it will merge anytime soon.

Copy link

Pull Request Test Coverage Report for Build kraen.hansen_76

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 58 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.002%) to 91.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/object-store/util/event_loop.cpp 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/realm/array_timestamp.cpp 1 97.77%
src/realm/index_string.cpp 1 85.17%
src/realm/list.cpp 1 87.37%
src/realm/mixed.cpp 1 86.46%
src/realm/sync/network/http.hpp 1 82.27%
src/realm/sync/noinst/server/server_history.cpp 1 62.92%
src/realm/uuid.cpp 1 98.48%
test/fuzz_tester.hpp 1 57.73%
test/object-store/util/event_loop.cpp 1 74.19%
src/realm/query_expression.cpp 2 86.62%
Totals Coverage Status
Change from base Build 2580: 0.002%
Covered Lines: 217376
Relevant Lines: 238621

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference T-Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant