Skip to content

Commit

Permalink
RJS-2815: React Native bridgeless support (take 2) (#6737)
Browse files Browse the repository at this point in the history
* Refactoring Android native module

* Upgrading RNTA and RN

* Refactoring iOS native module

* Enabling bridgeless on CI

* Deleting the old setBridge dependent code

* Injecting js_call invoker only if microtasks are disabled

* Fixed linting issues

* Enabling new arch and bridgeles from gradle properties

* Re-introducing the workaround

* Fixed logcat spawning

* Updating locks

* Adding a comment

* Fixed lint warnings

* Less explicit source_files in Podspec
  • Loading branch information
kraenhansen authored Jul 16, 2024
1 parent adda258 commit 96f7c04
Show file tree
Hide file tree
Showing 23 changed files with 787 additions and 1,311 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/pr-realm-js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,8 @@ jobs:
env:
USE_CCACHE: 1
USE_HERMES: 1
USE_BRIDGELESS: 0 # Disabling for now
RCT_NEW_ARCH_ENABLED: 0 # Disabled for now
USE_BRIDGELESS: 1
RCT_NEW_ARCH_ENABLED: 1
working-directory: integration-tests/environments/react-native-test-app/ios
timeout-minutes: 15
run: pod install --verbose
Expand All @@ -630,8 +630,6 @@ jobs:
- build-ts
- generate-jsi
- prebuild-android
env:
SPAWN_LOGCAT: true
runs-on: macos-latest-large
timeout-minutes: 60
steps:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
# Note that this is incompatible with web debugging.
#newArchEnabled=true
#bridgelessEnabled=true
newArchEnabled=true
bridgelessEnabled=true

# Uncomment the line below to build React Native from source.
#react.buildFromSource=true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async function run(spawnLogcat) {
if (PLATFORM === "android") {
// Start the log cat (skipping any initial pid from an old run)
if (spawnLogcat) {
logcat.start("com.realmreactnativetests", true).catch(console.error);
logcat.start("com.microsoft.reacttestapp", true).catch(console.error);
}
// Ask React Native to build and run the app
// Using --active-arch-only as per https://reactnative.dev/docs/build-speed#build-only-one-abi-during-development-android-only
Expand Down
Loading

0 comments on commit 96f7c04

Please sign in to comment.