Suggestion for default open behavior #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deprecate the static types that were imported from v11 * define the defaults locally in the ProgressRealmPromise * document what the defaults for these fields are in SyncConfiguration
elle-j
reviewed
Jul 10, 2023
Comment on lines
178
to
180
| static openLocalRealmBehavior = { | ||
| type: OpenRealmBehaviorType.OpenImmediately, | ||
| }; |
There was a problem hiding this comment.
Removing Readonly<OpenRealmBehaviorConfiguration> might have been accidental? (Same for static downloadBeforeOpenBehavior)
Also, see earlier comment regarding having this reference what is being used internally as well.
There was a problem hiding this comment.
Yes, that was accidental.
elle-j
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: