Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer version support for RN 72 #5970

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

takameyer
Copy link
Contributor

What, How & Why?

The current package.json had a pinned peer dependency on RN 71. This would cause an error when running npm install on RN 72 projects. The change ensures that we at least install on the newer version of RN.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

The current package.json had a pinned peer dependency on RN 71.  This would cause
an error when running npm install on RN 72 projects.  The change ensures that we
at least install on the newer version of RN.
@takameyer takameyer requested a review from elle-j July 7, 2023 12:12
@cla-bot cla-bot bot added the cla: yes label Jul 7, 2023
@takameyer takameyer requested a review from kneth July 7, 2023 12:12
@takameyer takameyer merged commit e1a87a9 into main Jul 10, 2023
29 of 32 checks passed
@takameyer takameyer deleted the andrew/fix-rn-peer-version branch July 10, 2023 13:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants