Refactor post-install script to not depend on fs-extra #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takameyer
approved these changes
Jul 11, 2023
elle-j
approved these changes
Jul 11, 2023
elle-j
reviewed
Jul 11, 2023
kraenhansen
reviewed
Jul 12, 2023
| @@ -127,8 +127,8 @@ function isAnalyticsDisabled() { | |||
| } | |||
|
|
|||
| function getRealmVersion() { | |||
| const packageJsonPath = path.resolve(__dirname, "../package.json"); | |||
| const packageJson = fse.readJsonSync(packageJsonPath); | |||
| const packageJsonPath = path.resolve(__dirname, "..", "package.json"); | |||
kraenhansen
reviewed
Jul 12, 2023
| @@ -139,7 +139,7 @@ function getRealmVersion() { | |||
| */ | |||
| function getRealmCoreVersion() { | |||
| const dependenciesListPath = path.resolve(__dirname, "../dependencies.list"); | |||
There was a problem hiding this comment.
I believe I deleted this file 🤔
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
No open issue for this.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: