Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prebuild script for windows #6010

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix prebuild script for windows #6010

merged 1 commit into from
Jul 27, 2023

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Jul 27, 2023

What, How & Why?

The publish action was outputting windows prebuilds into prebuilds\realm-v12.0.0-rc.2-napi-v6-win32-%PREBUILD_ARCH%.tar.gz, which shows a mismatch between unix based envs and windows env. The tool cross-env was being used to ensure this method worked, but the cross-env-shell variant was needed so that the env was made available in the shell executing the build script and not just the script itself.

This will fix any issues Windows users have had installing v12 in node environments.

This closes #6011

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated

* use cross-env-shell instead of cross-env
@takameyer takameyer merged commit 98b4920 into main Jul 27, 2023
27 of 32 checks passed
@takameyer takameyer deleted the win-fix branch July 27, 2023 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v12 Windows prebuilds missing for node
1 participant