Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks for client reset have been restored #6214

Merged
merged 18 commits into from
Nov 2, 2023
Merged

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Oct 24, 2023

What, How & Why?

The callbacks were not fired. The root cause was that they have not been exposed to the binding. Unfortunately the flexible sync tests are still timing out since the function triggerClientReset is not able to trigger it on the sync server. To make the function more robust, a retry mechanism is implemented (it is believed that the trigger will sometimes fail due to a race condition in the server).

This closes #6201

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kneth kneth self-assigned this Oct 24, 2023
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the tests being enabled again!

There seems to be some preexisting issues with fetching the server functions and some timeouts though.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/client-reset.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/client-reset.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/client-reset.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/client-reset.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/client-reset.ts Outdated Show resolved Hide resolved
@takameyer
Copy link
Contributor

Appears all the tests are failing consistently

Copy link

coveralls-official bot commented Oct 31, 2023

Coverage Status

coverage: 86.198% (+0.8%) from 85.405% when pulling 87e8c5e on kneth/client-reset into 7c11ceb on main.

@kneth kneth merged commit 791d4d4 into main Nov 2, 2023
34 of 35 checks passed
@kneth kneth deleted the kneth/client-reset branch November 2, 2023 12:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client reset callbacks not firing as expected
3 participants