Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export RealmEventName #6300

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Export RealmEventName #6300

merged 2 commits into from
Dec 5, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

As @elle-j noted in #6297 (comment) .. we could export and use RealmEventName here.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Dec 5, 2023
@kraenhansen kraenhansen mentioned this pull request Dec 5, 2023
Merged
7 tasks
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 86.51%. remained the same
when pulling 16dc82e on kh/realm-event-name-type
into 39d441c on main.

elle-j
elle-j approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kraenhansen kraenhansen merged commit 0ae91f6 into main Dec 5, 2023
35 checks passed
@kraenhansen kraenhansen deleted the kh/realm-event-name-type branch December 5, 2023 11:55
bimusiek pushed a commit to bimusiek/realm-js that referenced this pull request Mar 14, 2024
@kraenhansen @bimusiek
Export RealmEventName (realm#6300)
31fb2c7 
* Export and use `RealmEventName`

* Adding a note in the changelog
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

Assignees

@kraenhansen kraenhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @elle-j