Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created binding.gyp #6309

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Created binding.gyp #6309

merged 1 commit into from
Dec 8, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #3828

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Dec 8, 2023
@coveralls-official Coveralls Official
Copy link

Coverage Status

coverage: 86.51%. remained the same
when pulling c8eea27 on kh/binding-gyp-stub
into 81353d1 on main.

elle-j
elle-j approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@kraenhansen kraenhansen merged commit ca5f3db into main Dec 8, 2023
31 of 35 checks passed
@kraenhansen kraenhansen deleted the kh/binding-gyp-stub branch December 8, 2023 09:35
bimusiek pushed a commit to bimusiek/realm-js that referenced this pull request Mar 14, 2024
@kraenhansen @bimusiek
Created binding.gyp (realm#6309)
feb0fae
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

Assignees

@kraenhansen kraenhansen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prebuilt binaries aren't fetched when packaging an Electron app
2 participants
@kraenhansen @elle-j