Adding inspect.custom symbol on RealmObject and Collection on Node
#6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
force-pushed
the
kh/custom-inspect-on-node
branch
from
92debaf
to
bea0b72
Compare
kneth
approved these changes
Dec 13, 2023
takameyer
approved these changes
Dec 13, 2023
elle-j
approved these changes
Dec 13, 2023
Comment on lines
20
to
21
| import { Collection, Dictionary, List, RealmObject, RealmSet } from "../../internal"; | ||
| import { Results } from "realm/binding"; |
There was a problem hiding this comment.
Preferable to use imports via "realm" instead?
There was a problem hiding this comment.
Indeed - good catch, this is the wrong Results!
|
Merging now since the failing tests seem unrelated. |
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
…ealm#6315) * Adding inspect.custom symbol on RealmObject and Collection on Node * Adding an entry to the changelog * Improved it a bit * The possiblyShort helper is no longer needed * Updated wrong import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
I finally got tired of the lack of property values on objects as they're being logged and implemented a custom inspect function for
Realm.ObjectandRealm.Collection.This is the output of logging first a
Realm.Objectwith a string, list, set and dictionary properties.This closes #2758.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary