Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build iOS from source #6353

Closed
wants to merge 14 commits into from
Closed

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Jan 4, 2024

What, How & Why?

  • Created a copy of the old build script which is invoked from the Podspec
  • Modified Podspec to load libraries vs xcframework
  • Created a script phase within Podspec to invoke cmake and build libraries
  • Updated supported iOS version to mirror RN (from 9 to 13. this was causing many warnings)

TODO: Something went wrong when setting ccache in the int-tests RN project. Removed this for now.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

Copy link

coveralls-official bot commented Jan 4, 2024

Coverage Status

coverage: 85.841%. remained the same
when pulling 4d6d0b2 on andrew/bo/ios-src-build
into 0a8a70c on andrew/bo/reorg.

* build from core prebuilds
* phase script only called when input and outputs have changes
* reinstalling pods will wipe build files, forcing a rebuild
* generate input file list so that core can be rebuilt on changes
* generate dummy libraries so that libraries can be generated
* create build option which forces core to build from source
* build from source if prebuild url is not reachable
* update the packed contents of the package
* update relevant documentation
@takameyer
Copy link
Contributor Author

Replaced by #6396 as I couldn't resolve merge conflicts.

@takameyer takameyer closed this Jan 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant