Remove node-fetch dependency from SDK, introduce @realm/fetch and allow passing fetch through AppConfiguration

.github/workflows/package-unit-tests.yml

@@ -26,7 +26,6 @@ jobs:
       matrix:
         workspace:
           - realm
-          - '@realm/network-transport'
           - '@realm/babel-plugin'
           - '@realm/react'
         include:

.github/workflows/pr-realm-web.yml

@@ -6,7 +6,6 @@ on:
       # Only run when the PR makes changes to the packages
       - "packages/realm-web/**"
       - "packages/realm-web-integration-tests/**"
-      - "packages/realm-network-transport/**"
       - "packages/realm-common/**"
       - "packages/realm-app-importer/**"
       # Changing types might also affect Realm Web

.github/workflows/prepare-package-release.yml

@@ -15,7 +15,6 @@ on:
         options:
         - '@realm/babel-plugin'
         - '@realm/common'
-        - '@realm/network-transport'
         - '@realm/react'
         - '@realm/tools'
         - '@realm/web'
@@ -41,11 +40,6 @@ jobs:
                 "PACKAGE_NAME": "@realm/common",
                 "VERSION_PREFIX": "realm-common-"
               },
-              "@realm/network-transport": {
-                "PACKAGE_PATH": "packages/realm-network-transport",
-                "PACKAGE_NAME": "@realm/network-transport",
-                "VERSION_PREFIX": "realm-network-transport-"
-              },
               "@realm/react": {
                 "PACKAGE_PATH": "packages/realm-react",
                 "PACKAGE_NAME": "@realm/react",

.github/workflows/publish-package-release.yml

@@ -20,7 +20,6 @@ on:
         options:
         - '@realm/babel-plugin'
         - '@realm/common'
-        - '@realm/network-transport'
         - '@realm/react'
         - '@realm/tools'
         - '@realm/web'
@@ -50,13 +49,6 @@ jobs:
               "RELEASE_TITLE": "Realm Common",
               "SDK_NAME": "Common"
             },
-            "@realm/network-transport": {
-              "PACKAGE_PATH": "packages/realm-network-transport",
-              "PACKAGE_NAME": "@realm/network-transport",
-              "VERSION_PREFIX": "realm-network-transport-",
-              "RELEASE_TITLE": "Realm Network Transport",
-              "SDK_NAME": "Network Transport"
-            },
             "@realm/react": {
               "PACKAGE_PATH": "packages/realm-react",
               "PACKAGE_NAME": "@realm/react",

CHANGELOG.md

@@ -4,7 +4,7 @@
 * None
 
 ### Enhancements
-* None
+* Added an optional `fetch` parameter to the `AppConfiguration`. Use this to specify a custom implementation of the `fetch` function used by the app to perform network requests.
 
 ### Fixed
 * <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)

integration-tests/environments/electron/package.json

@@ -27,17 +27,15 @@
       "dependencies": [
         "../../../packages/realm:bundle",
         "../../../packages/realm:build:node",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ]
     },
     "test:renderer": {
       "command": "mocha-remote --reporter @realm/mocha-reporter --id renderer tsx runner.ts renderer",
       "dependencies": [
         "../../../packages/realm:bundle",
         "../../../packages/realm:build:node",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ]
     }
   },

integration-tests/environments/node/package.json

@@ -15,17 +15,15 @@
       "dependencies": [
         "../../../packages/realm:bundle",
         "../../../packages/realm:build:node",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ]
     },
     "test:commonjs": {
       "command": "mocha-remote --reporter @realm/mocha-reporter tsx index.cjs",
       "dependencies": [
         "../../../packages/realm:bundle",
         "../../../packages/realm:build:node",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ]
     }
   },

integration-tests/environments/react-native/package.json

@@ -99,8 +99,7 @@
       "dependencies": [
         "../../../packages/realm:build:android",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "android",
@@ -118,8 +117,7 @@
       "dependencies": [
         "pod-install:simulator",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "ios",
@@ -131,8 +129,7 @@
       "dependencies": [
         "pod-install:catalyst",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "catalyst",
@@ -159,8 +156,7 @@
       "dependencies": [
         "../../../packages/realm:build:android",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "android",
@@ -173,8 +169,7 @@
         "pod-install:simulator",
         "../../../packages/realm:build:ios:debug:simulator",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "ios",
@@ -187,8 +182,7 @@
         "pod-install:catalyst",
         "../../../packages/realm:build:ios:debug:catalyst",
         "../../../packages/realm:bundle",
-        "../../../packages/mocha-reporter:bundle",
-        "../../../packages/realm-network-transport:bundle"
+        "../../../packages/mocha-reporter:bundle"
       ],
       "env": {
         "PLATFORM": "catalyst",

integration-tests/tests/package.json

@@ -1,101 +1,97 @@
 {
-	"name": "@realm/integration-tests",
-	"version": "0.1.0",
-	"description": "A set of tests that can run in different environments",
-	"main": "src/index.ts",
-	"exports": {
-		".": "./src/index.ts",
-		"./node": "./src/node/index.ts"
-	},
-	"private": true,
-	"scripts": {
-		"build": "wireit",
-		"start": "wireit",
-		"test": "wireit",
-		"lint": "wireit",
-		"coverage": "wireit",
-		"ci:coverage": "wireit"
-	},
-	"wireit": {
-		"lint": {
-			"command": "eslint --ext .js,.ts . && tsc --noEmit",
-			"dependencies": [
-				"../../packages/realm-network-transport:bundle",
-				"../../packages/realm:bundle"
-			]
-		},
-		"build": {
-			"command": "tsc",
-			"dependencies": [
-				"../../packages/realm:bundle",
-				"build-dependencies"
-			]
-		},
-		"start": {
-			"command": "mocha --watch",
-			"dependencies": [
-				"../../packages/realm:bundle",
-				"build-dependencies"
-			]
-		},
-		"test": {
-			"command": "mocha --exit",
-			"dependencies": [
-				"../../packages/realm:bundle",
-				"build-dependencies"
-			]
-		},
-		"coverage": {
-			"command": "nyc mocha --exit",
-			"dependencies": [
-				"../../packages/realm:bundle:coverage",
-				"build-dependencies"
-			]
-		},
-		"ci:coverage": {
-			"command": "nyc --reporter=lcov -- mocha --exit",
-			"dependencies": [
-				"../../packages/realm:bundle:coverage",
-				"build-dependencies"
-			]
-		},
-		"build-dependencies": {
-			"dependencies": [
-				"../../packages/realm:build:node",
-				"../../packages/mocha-reporter:bundle",
-				"../../packages/realm-network-transport:bundle"
-			]
-		}
-	},
-	"peerDependencies": {
-		"realm": "*"
-	},
-	"devDependencies": {
-		"@istanbuljs/nyc-config-typescript": "^1.0.2",
-		"@realm/app-importer": "*",
-		"@realm/mocha-reporter": "*",
-		"@thi.ng/bench": "^3.1.16",
-		"@types/chai": "^4.3.3",
-		"@types/chai-as-promised": "^7.1.5",
-		"@types/jsrsasign": "^10.5.4",
-		"@types/mocha": "^10.0.0",
-		"@types/node": "^18.15.10",
-		"concurrently": "^6.5.1",
-		"mocha": "^10.1.0",
-		"node-fetch": "^2.6.9",
-		"nyc": "^15.1.0",
-		"platform": "^1.3.6",
-		"realm": "*"
-	},
-	"dependencies": {
-		"@realm/network-transport": "^0.7.2",
-		"@thi.ng/bench": "^3.1.16",
-		"chai": "4.3.6",
-		"chai-as-promised": "^7.1.1",
-		"concurrently": "^6.0.2",
-		"jsrsasign": "^11.0.0"
-	},
-	"files": [
-		"/src"
-	]
-}
+  "name": "@realm/integration-tests",
+  "version": "0.1.0",
+  "description": "A set of tests that can run in different environments",
+  "main": "src/index.ts",
+  "exports": {
+    ".": "./src/index.ts",
+    "./node": "./src/node/index.ts"
+  },
+  "private": true,
+  "scripts": {
+    "build": "wireit",
+    "start": "wireit",
+    "test": "wireit",
+    "lint": "wireit",
+    "coverage": "wireit",
+    "ci:coverage": "wireit"
+  },
+  "wireit": {
+    "lint": {
+      "command": "eslint --ext .js,.ts . && tsc --noEmit",
+      "dependencies": [
+        "../../packages/realm:bundle"
+      ]
+    },
+    "build": {
+      "command": "tsc",
+      "dependencies": [
+        "../../packages/realm:bundle",
+        "build-dependencies"
+      ]
+    },
+    "start": {
+      "command": "mocha --watch",
+      "dependencies": [
+        "../../packages/realm:bundle",
+        "build-dependencies"
+      ]
+    },
+    "test": {
+      "command": "mocha --exit",
+      "dependencies": [
+        "../../packages/realm:bundle",
+        "build-dependencies"
+      ]
+    },
+    "coverage": {
+      "command": "nyc mocha --exit",
+      "dependencies": [
+        "../../packages/realm:bundle:coverage",
+        "build-dependencies"
+      ]
+    },
+    "ci:coverage": {
+      "command": "nyc --reporter=lcov -- mocha --exit",
+      "dependencies": [
+        "../../packages/realm:bundle:coverage",
+        "build-dependencies"
+      ]
+    },
+    "build-dependencies": {
+      "dependencies": [
+        "../../packages/realm:build:node",
+        "../../packages/mocha-reporter:bundle"
+      ]
+    }
+  },
+  "peerDependencies": {
+    "realm": "*"
+  },
+  "devDependencies": {
+    "@istanbuljs/nyc-config-typescript": "^1.0.2",
+    "@realm/app-importer": "*",
+    "@realm/mocha-reporter": "*",
+    "@thi.ng/bench": "^3.1.16",
+    "@types/chai": "^4.3.3",
+    "@types/chai-as-promised": "^7.1.5",
+    "@types/jsrsasign": "^10.5.4",
+    "@types/mocha": "^10.0.0",
+    "concurrently": "^6.5.1",
+    "mocha": "^10.1.0",
+    "nyc": "^15.1.0",
+    "platform": "^1.3.6",
+    "realm": "*"
+  },
+  "dependencies": {
+    "@thi.ng/bench": "^3.1.16",
+    "chai": "4.3.6",
+    "chai-as-promised": "^7.1.1",
+    "concurrently": "^6.0.2",
+    "jsrsasign": "^11.0.0",
+    "node-fetch": "^3.3.2"
+  },
+  "files": [
+    "/src"
+  ]
+}

integration-tests/tests/src/node/index.ts

@@ -24,3 +24,4 @@ import "./path";
 import "./sync-proxy";
 import "./custom-inspect";
 import "./ssl";
+import "./node-fetch";