Update build-android.js to use the ANDROID_HOME environment variable
#6402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://developer.android.com/tools/variables `ANDROID_SDK_ROOT` is deprecated.
|
Can this be merged into #6400 ? Or does this need to be in |
|
I updated my local environment to match the recommended, which is why I'd like it to merge soon 😊 |
takameyer
approved these changes
Jan 22, 2024
kraenhansen
added a commit
that referenced
this pull request
Jan 23, 2024
7 tasks
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
…ble (realm#6402) According to https://developer.android.com/tools/variables `ANDROID_SDK_ROOT` is deprecated.
bimusiek
pushed a commit
to bimusiek/realm-js
that referenced
this pull request
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
According to https://developer.android.com/tools/variables
ANDROID_SDK_ROOTis deprecated.