Remove fs-extra
#6407
Closed
Remove fs-extra
#6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Jan 25, 2024
| @@ -39,7 +39,7 @@ describe("Analytics", () => { | |||
|
|
|||
| function getRealmVersion() { | |||
| const packageJsonPath = path.resolve(__dirname, "../../../../packages/realm/package.json"); | |||
| const packageJson = fse.readJsonSync(packageJsonPath); | |||
| const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, "utf-8")); | |||
There was a problem hiding this comment.
This was the only actual use of an API that isn't provided by node:fs.
|
Changes unknown |
|
Closing as it's unlikely this will ever merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
As an alternative to #6373, this removes all use of the
fs-extrapackage.We weren't actually using it in ways that couldn't easily be replaced by
node:fs, so I think we should just avoid it to simplify things and get one less dependency.In draft
It turns out that since
existsdoesn't return aPromisewhen called fromnode:fs, the libraries cannot be easily replaced, I think we should rethink the way we providefsandpathimplementations to the tests: #6408☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary