Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2760: Adding Realm.shutdown() and fixing clean exit tests #6571

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Mar 22, 2024

What, How & Why?

This closes #6555, #5781, #4535, #6096, #6357, #4530, #3616 by adding a static Realm.shutdown method, which closes all Realms, cancels all pending Realm.open calls, clears internal caches, resets the logger and collects garbage.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great debugging session 🥳

@@ -0,0 +1,27 @@
////////////////////////////////////////////////////////////////////////////
//
// Copyright 2022 Realm Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2022 Realm Inc.
// Copyright 2024 Realm Inc.

@kraenhansen kraenhansen force-pushed the kh/clean-exits-2 branch 2 times, most recently from a2e3900 to 7e5980f Compare March 23, 2024 10:14
@kraenhansen
Copy link
Member Author

Rebased on main which has the changes we need with #6598.

@kraenhansen
Copy link
Member Author

Coverage test is still crashing (#6589) but that's not new - I'll go ahead and merge with it.

@kraenhansen kraenhansen merged commit 4063879 into main Apr 10, 2024
31 of 32 checks passed
@kraenhansen kraenhansen deleted the kh/clean-exits-2 branch April 10, 2024 10:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Realm.shutdown()
3 participants