Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAuth2Helper to remove accessing the stitch prefix #6659

Merged
merged 2 commits into from
May 7, 2024

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented May 6, 2024

What, How & Why?

This removes fallback of reading values from the _stitch_ prefix of the OAuth 2 redirect response query string.
Related to #6657 but not exactly the same (since this doesn't relate to the access token).

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen added the no-jira-ticket Skip checking the PR title for Jira reference label May 6, 2024
@kraenhansen kraenhansen self-assigned this May 6, 2024
@cla-bot cla-bot bot added the cla: yes label May 6, 2024
@kraenhansen kraenhansen requested review from kneth and elle-j May 6, 2024 12:18
@kraenhansen
Copy link
Member Author

Merging as the build error is unrelated to the changes.

@kraenhansen kraenhansen merged commit b3a2525 into main May 7, 2024
33 of 34 checks passed
@kraenhansen kraenhansen deleted the kh/avoid_stitch_prefix branch May 7, 2024 12:08
papafe added a commit that referenced this pull request May 23, 2024
* main: (22 commits)
  Prepare for vNext (#6677)
  [12.9.0] Bump version (#6676)
  Fix performance tests (#6665)
  Combined: Support `Mixed` data type with collections (#6613)
  Update expected error messages (#6674)
  Adding --latest-local to the baas test server CLI (#6673)
  Upgrade to Realm Core v14.7.0 (#6663)
  Upgrade @trunk/launcher to v1.3.1 to support Apple's versioning scheme for macOS (#6671)
  Prepare for vNext (#6669)
  [12.8.1] Bump version (#6668)
  Use unreleased core (#6667)
  Fix realm/react changelog (#6661)
  Fix GHA error when publishing package release (#6660)
  Prepend vNext to realm/react changelog.
  [realm-react-0.7.0] Bump version (#6658)
  Update OAuth2Helper to remove accessing the stitch prefix (#6659)
  Fix unresolvable links in API reference docs and remove re-exports (#6646)
  Prepare for vNext (#6645)
  [12.8.0] Bump version (#6643)
  Upgrade to HEAD of Realm Core's master (#6637)
  ...

# Conflicts:
#	CHANGELOG.md
#	integration-tests/tests/src/tests/mixed.ts
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants