Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2809: Realm Web: Fix async iterator returned from watch #6688

Merged
merged 2 commits into from
May 30, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #6634.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this May 29, 2024
@cla-bot cla-bot bot added the cla: yes label May 29, 2024
@kraenhansen kraenhansen requested a review from elle-j May 29, 2024 15:16
@kraenhansen kraenhansen changed the title Realm Web: Fix async iterator returned from watch RJS-2809: Realm Web: Fix async iterator returned from watch May 29, 2024
@kraenhansen kraenhansen requested a review from kneth May 29, 2024 18:45
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun Chrome debugging ride 🙂

@kraenhansen kraenhansen merged commit 81ba4a2 into main May 30, 2024
34 of 36 checks passed
@kraenhansen kraenhansen deleted the kh/web/fix-async-iterator branch May 30, 2024 10:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling stream.return() on chrome 124 crashes browser
3 participants